Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvements made on the LED bracket to ensure that the light from each LED remains isolated and independent.
Technical details
Abandons the modular design of having an LED strip mount base and a separate face place. The goal from that was to be able to make the shapes of the lights interchangeable, such as visualizing rounded squares, or circles. Too much light would bleed through the cracks, making a solid design preferable.
Computed dimensions were added, allowing the bracket to be made with any arbitrary length. Edit the
LED Countfield in theglobalsspreadsheet to add/remove LEDs.